Hi Rakesh, On 1/11/2011 2:41 AM, Rakesh Iyer wrote: > Thanks for the review. > > A quick response regarding the following comment. > >> >>> + >>> +#include <linux/module.h> >>> +#include <linux/input.h> >>> +#include <linux/platform_device.h> >>> +#include <linux/delay.h> >>> +#include <linux/io.h> >>> +#include <linux/interrupt.h> >>> +#include <linux/clk.h> >>> +#include <linux/slab.h> >>> +#include <mach/clk.h> >> >> You may not need this. >> > > The mach/clk.h file contains declarations for tegra_periph_reset_assert and tegra_periph_reset_deassert which are needed. It is really bad if it can't be addressed through clk framework. I will check this, but this keyboard controller is on-chip so we should be fine I guess. I hope that these APIs are not required for device drivers which are on external bus like I2C. ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
