> -----Original Message----- > From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On > Behalf Of Randy Dunlap > Sent: Thursday, January 06, 2011 2:27 PM > To: Jesper Juhl > Cc: Rakesh Iyer; tsoni@xxxxxxxxxxxxxx; shubhrajyoti@xxxxxx; ccross@xxxxxxxxxxx; > konkers@xxxxxxxxxxx; olof@xxxxxxxxx; Andrew Chew; linux-tegra@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver > > On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote: > > > > +fail: > > > + if (kbc->irq >= 0) > > > + free_irq(kbc->irq, pdev); > > > + if (kbc->idev) > > > + input_free_device(kbc->idev); > > > > As far as I can tell input_free_device() deals gracefully with being > > passed a null pointer, so the 'if' seems superfluous. > > > > > > -- > > Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ > > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > > Plain text mails only, please. > + Please trim replies to the relevant part(s) of patches. > > > thnx, > --- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ Is having this check really an issue? Can't input_free_device change in the future so that NULL as a parameter does cause undesirable side-effects? Regards Rakesh -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
