Re: [patch] input/tc3589x: fix compile error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/1/5 Dan Carpenter <error27@xxxxxxxxx>:
> On Wed, Jan 05, 2011 at 02:01:01AM +0100, Linus Walleij wrote:
>> 2011/1/4 Dan Carpenter <error27@xxxxxxxxx>:
>>
>> > There was a semi-colon missing and it broke the compile.
>>
>> How come my setup compiles then... Oh well, probably a more
>> forgiving compiler.
>
> The only explanation I can think of is that you're compiling the driver
> into the kernel instead of as a module?

Yes that's it, hm the macro __MODULE_INFO() resolves to
nothing if compiled-in and resolves to something needing
a semicolon otherwise.

This makes some errors pass under the radar, looks
syntactically unsound to me :-(

I'll cook up a patch.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux