On Fri, Dec 31, 2010 at 06:25:51PM +0530, Trilok Soni wrote: > Hi Henrik, > > On 12/31/2010 5:23 PM, Henrik Rydberg wrote: > > Hi Kevin, > > > > Thanks for the changes, it looks much better now. Some comments on the MT > > part inline. > > > >> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > >> index 06ea8da..7d886bc 100644 > >> --- a/drivers/input/touchscreen/Kconfig > >> +++ b/drivers/input/touchscreen/Kconfig > >> @@ -124,6 +124,11 @@ config TOUCHSCREEN_CY8CTMG110 > >> To compile this driver as a module, choose M here: the > >> module will be called cy8ctmg110_ts. > >> > >> +config TOUCHSCREEN_CYTTSP_CORE > >> + bool "Cypress TTSP touchscreen core" > >> + help > >> + Always activated for Cypress TTSP touchscreen > >> + > > > > Tristate please. > > This code is just exporting APIs and doesn't need to be modular. No module_init/exit etc., Any particular reason why "grep cytt /proc/kallsyms | wc" should be non-zero when no suitable hardware is available? Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
