On Tue, Dec 28, 2010 at 11:42 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Tue, Dec 28, 2010 at 11:40:58PM -0800, Dmitry Torokhov wrote:
>> Hi Ping,
>>
>> On Fri, Dec 17, 2010 at 09:37:54AM -0800, Ping Cheng wrote:
>> > Signed-off-by: Ping Cheng <pingc@xxxxxxxxx>
>> > ---
>> > drivers/input/touchscreen/wacom_w8001.c | 89 ++++++++++++++++++++++++++++---
>> > 1 files changed, 82 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c
>> > index 59664a8..763eb8f 100644
>> > --- a/drivers/input/touchscreen/wacom_w8001.c
>> > +++ b/drivers/input/touchscreen/wacom_w8001.c
>> > @@ -3,6 +3,7 @@
>> > *
>> > * Copyright (c) 2008 Jaya Kumar
>> > * Copyright (c) 2010 Red Hat, Inc.
>> > + * Copyright (c) 2010 Ping Cheng, Wacom. <pingc@xxxxxxxxx>
>> > *
>> > * This file is subject to the terms and conditions of the GNU General Public
>> > * License. See the file COPYING in the main directory of this archive for
>> > @@ -86,6 +87,12 @@ struct w8001 {
>> > char phys[32];
>> > int type;
>> > unsigned int pktlen;
>> > + bool pen_in_prox;
>> > + bool has_touch;
>>
>> We already have type, why do we need these 2 fields a well?
>>
>> Actually, I tried massaging the patch a bit, could you please tell me if
>> the patch below still works for you?
>>
>> Thanks.
>>
>
> And while we are at it could you please try this patch as well...
>
> Thank you!
>
> --
> Dmitry
>
> Input: wacom_w8001 - add single-touch pointer emulation
>
> Let's emit single-touch compatible events for the 2-finger panels so that
> they can be used with legacy clients.
Depending on which legacy clients we are talking about, this patch may
introduce issue instead of support. We added
mt_report_pointer_emulation for Bamboo since it is a touchpad, that
can be driven by xf86-input-synaptics in relative mode. This device is
a touchscreen, that should be run in absolute mode. If we emulate ST
events, which X driver do we expect it to use? xf86-input-wacom does
not process emulated single touch data once we know MT is supported.
That's why I didn't want to add ST emulation for this device.
We expect clients that support this MT device will be in MT format
since this driver is new and the clients have to run inputattach to
enable the port before they can talk to the device. The client must
have a reason to do so. Do you see any legacy clients would like to
walk the extra mile to use this driver?
Ping
> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> ---
>
> drivers/input/touchscreen/wacom_w8001.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>
> diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c
> index ce8c8e1..01489f7 100644
> --- a/drivers/input/touchscreen/wacom_w8001.c
> +++ b/drivers/input/touchscreen/wacom_w8001.c
> @@ -145,6 +145,7 @@ static void parse_multi_touch(struct w8001 *w8001)
> }
> }
>
> + input_mt_report_pointer_emulation(dev, true);
> input_sync(dev);
> }
>
> @@ -420,6 +421,9 @@ static int w8001_setup(struct w8001 *w8001)
> 0, touch.y, 0, 0);
> input_set_abs_params(dev, ABS_MT_TOOL_TYPE,
> 0, MT_TOOL_MAX, 0, 0);
> +
> + __set_bit(BTN_TOOL_DOUBLETAP, dev->keybit);
> +
> break;
> }
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
