> > Reported-by: Tobyn Bertram
> > Not-yet-signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > Not-yet-signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
> > Not-yet-signed-off-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>
> > Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
>
> You can keep my SOB.
Great, thanks.
> > +static void set_slot(struct input_dev *dev, int slot, bool active, int x, int y)
> > +{
> > + input_mt_slot(dev, slot);
> > + input_mt_report_slot_state(dev, MT_TOOL_FINGER, active);
> > + if (active) {
> > + input_report_abs(dev, ABS_MT_POSITION_X, x);
> > + input_report_abs(dev, ABS_MT_POSITION_Y,
> > + YMAX_NOMINAL + YMIN_NOMINAL - y);
> > + }
> > +}
>
> I take it that you feel MT_TOOL_FINGER should always be set, even if
> it's always the same as BTN_TOOL_*? I just want to be sure this is
> intended so we document it appropriately.
Yes - the MT_TOOLs are only emitted when explicitly set in absbit, but
the internal interface always handles it. This is actually documented
in the code (and DocBook).
>
> > @@ -623,6 +686,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)
> > int i;
> >
> > __set_bit(INPUT_PROP_POINTER, dev->propbit);
> > + __set_bit(INPUT_PROP_SEMI_MT, dev->propbit);
>
> Shouldn't this only be set when SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) is
> true?
Indeed - thanks.
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
