On Tue, Dec 07, 2010 at 10:29:21AM +0800, Lee, Chun-Yi wrote: > + struct lm_return_value return_value; > + acpi_status status; > + struct lm_input_params params = { > + .function_num = 0x1, > + .commun_devices = 0x0041, /* WiFi on, 3G on, BT off */ Why this set of devices? > + printk(ACER_INFO "Enabled Launch Manager"); This is the default behaviour, so I don't think you need to print anything in this case. The other patches in the series look fine - I'll apply those to -next now. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html