Re: [PATCH] Keyboard: omap-keypad: use matrix_keypad.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 17, 2010 at 8:29 PM, Cory Maccarrone <darkstar6262@xxxxxxxxx> wrote:
> On Fri, Dec 17, 2010 at 2:32 PM, Janusz Krzysztofik
> <jkrzyszt@xxxxxxxxxxxx> wrote:
>> Most keypad drivers make use of the <linux/input/matrix_keypad.h>
>> defined macros, structures and inline functions.
>>
>> Convert omap-keypad driver to use those as well, as suggested by a
>> compile time warning, hardcoded into the OMAP <palt/keypad.h>.
>>
>> Created against linux-2.6.37-rc5.
>> Tested on Amstrad Delta.
>> Compile tested with omap1_defconfig and omap2plus_defconfig shrinked to
>> board-h4.
>>
>> Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
>> ---
>
> Works perfectly on the herald, and no more warning message. ÂGood work!
>
> Tested-by: Cory Maccarrone <darkstar6262@xxxxxxxxx>
>
> - Cory
>

Hmm, I may have spoken too soon.  This works perfectly on the latest
Torvalds master branch, but does not seem to work applied to
linux-omap/master.  There, all my keys report the same KEY_RECORD
event.

Probably not a problem in this patch, I think -- will try and track it
down.  Out of curiosity, which branch did you test it on?

- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux