On Tue, Dec 14, 2010 at 06:31:20AM +0100, Sundar R IYER wrote: > Hi Dmitry, > > >I do not see where you'd enable the keypad. What will happen if you > >unbind/unload the driver (which will cause explicit call to disable) and > >then try loading the module again? > > A minor doubt: I enable the keypad in the open call; leaving it to the user > space to control the input device. If I understand your question, then I > should not be disabling the keypad in the tc3589x_keypad_remove, which > might cause conflicts. Is my understanding correct? Ah, I missed the fact that you have open and close. I think the best way would be to serialize open/close/suspend/resume (you can use dev->mutex) in suspend/resume and track device state so that you: 1. On resume do not enable the device if it hasn't been opened. 2. Can remove disable in remove(). Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
