Re: [PATCH 1/2] input: mt: Support separate contact and finger count reports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 11, 2010 at 11:28:27AM +0100, Henrik Rydberg wrote:
> A number of old and semi-recent touch devices are capable of counting
> the number of fingers on the pad within being able to give details for
> all individual contacts. This patch simplifies reporting for such
> hardware by providing a separate function for finger count.
> 

Looks good, just a couple nits below.

>  
>  /**
> + * input_mt_report_finger_count() - report contact count via buttons

"via buttons" is awkward, I'd simply dropped it,

> + * @dev: input device with allocated MT slots
> + * @count: the number of contacts
> + *
> + * Reports the contact count via BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP,
> + * BTN_TOOL_TRIPLETAP and BTN_TOOL_QUADTAP.
> + *
> + * The input core ensures only the KEY axes already setup for

s/axes/events/ ?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux