----- Original Nachricht ---- Von: Jiri Kosina <jkosina@xxxxxxx> An: Stefan Achatz <erazor_de@xxxxxxxxxxxxxxxxxxxxx> Datum: 09.12.2010 14:30 Betreff: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation > On Fri, 26 Nov 2010, Stefan Achatz wrote: > > > Adding sysfs attributes to an already created device raises no userland > > notification. > > > > Instead of fiddling around in the depths of busses and devices I reuse > the > > event char device (module hid-roccat). This device gets now created with > > a hardware specific class that contains the device attributes. > > Hi Stefan, > > I have applied the series, and removed the #pragma pack ugliness. Thanks, Hello Jiri, Using my patch replacing the #pragma pack with the __packed macro would have saved you some time: https://lkml.org/lkml/2010/11/27/14 Just for the future: Whats better using the verbose version __attribute__ ((__packed__)) or the macro __packed as I did? Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
