Hi Joey,
On Sat, Dec 04, 2010 at 09:03:24AM +0800, Lee, Chun-Yi wrote:
>
> +static acpi_status
> +wmid3_set_lm_mode(struct lm_input_params *params,
> + struct lm_return_value *return_value)
> +{
> + acpi_status status;
> + union acpi_object *obj;
> +
> + struct acpi_buffer input = { sizeof(struct lm_input_params), params };
> + struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
> +
> + status = wmi_evaluate_method(WMID_GUID3, 0, 0x1, &input, &output);
> + if (ACPI_FAILURE(status))
> + return status;
> +
> + obj = output.pointer;
> +
> + if (!obj)
> + return -EINVAL;
> + else if (obj->type != ACPI_TYPE_BUFFER) {
> + kfree(obj);
> + return -EINVAL;
Just noticed - this function (and others similar to this in your
subsequent patces) mixes acpi-style return values (acpi_status) with
Linux ones (-ERRXXX). You need to pick one standard (I'd advocate Linux
style) and stick with it.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
