Hi Shubhra/Dmitry, Thanx for your comments. >-----Original Message----- >From: Datta, Shubhrajyoti [mailto:shubhrajyoti@xxxxxx] > >Be careful about the permissions. > >This need not be __devinit as the sysfs hooks may need it. > >Could you use tabs instead of spaces here. >-----Original Message----- >From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > >The driver looks very reasonably with the exception of enable/disable >sysfs attribute and its handling. As I mentioned in few other threads we >can't keep adding custom PM methods to the drivers; instead we need to >move this functionality into PM/driver core and allow userspace >accelerate putting devices into low power state. > >BTW, I think spotted a few instances of space vs tab indentation and a >few pointless casts from (void *). As I mentioned, this is not the final patch. This patch is for Ken to try to work out the TC35894 keypad in this MFD plugged-in driver. I don't have access to the TC35894 data sheet; but going through the register definitions in the patch posted by Alan, I don't see any register changes and the same driver *should* just work out fine. Anyways I will re-post this series updated with your and Dmitry's comments. I also need to push out the TC35892 MFD driver updated to the MFD maintainer also. Cheers! -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
