Hi Sundar, On Fri, Nov 26, 2010 at 04:11:05PM +0100, Sundar R IYER wrote: > Hi Ken/Dmitry and all, > > This is the preliminary patch which I have got the TC35893 keypad working > plugged in as a MFD client. > > The MFD functions which are tc3589x_* are a find-replace for the tc35892 > functions in the existing MFD driver. Also added are a few definitions for > the keypad platform data. I (realize now :() will also send out this patch too > for reference. > > This is just a as-is driver migrated from our internal driver for the TC35893 > standalone keypad driver; I may have missed removing redundant and legacy > code yet; but this is for Ken and Co. as a TC35893(x) plugged into the MFD. > The driver looks very reasonably with the exception of enable/disable sysfs attribute and its handling. As I mentioned in few other threads we can't keep adding custom PM methods to the drivers; instead we need to move this functionality into PM/driver core and allow userspace accelerate putting devices into low power state. BTW, I think spotted a few instances of space vs tab indentation and a few pointless casts from (void *). Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
