This is for kernel bug #18122 and MeeGo bug #4807. Current code detects Clickpad by checking the 8 and 20 bits of 0x0c cap. However, the code returns true if either of those bits is 1, while it should only return true when both are 1. This has lead to the touchpad on Lenovo S10-3t be mistakenly recognized as Clickpad and its BTN_LEFT and BTN_RIGHT blocked. So far we've found that the S10-3ts are shipped with two slightly different models of touchpads, of which the 0x0c cap is either 0x5a0400 or 0x4a0500. They are not Clickpad and return BTN_LEFT and BTN_RIGHT normally. This patch fixed this issue by checking both sign bits are 1. Tested on my S10-3t and worked well. Signed-off-by: Yan Li <yan.i.li@xxxxxxxxx> --- drivers/input/mouse/synaptics.h | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/input/mouse/synaptics.h b/drivers/input/mouse/synaptics.h index 613a365..0c1083c 100644 --- a/drivers/input/mouse/synaptics.h +++ b/drivers/input/mouse/synaptics.h @@ -51,7 +51,11 @@ #define SYN_EXT_CAP_REQUESTS(c) (((c) & 0x700000) >> 20) #define SYN_CAP_MULTI_BUTTON_NO(ec) (((ec) & 0x00f000) >> 12) #define SYN_CAP_PRODUCT_ID(ec) (((ec) & 0xff0000) >> 16) -#define SYN_CAP_CLICKPAD(ex0c) ((ex0c) & 0x100100) +/* Synaptics' ClickPad has both 8th and 20th bits set in the 0x0c + * cap. Other models (like those shipped with Lenovo S10-3t) may have + * either one of them set but not both, and they are *not* ClickPad + * although they look similar. */ +#define SYN_CAP_CLICKPAD(ex0c) ((ex0c) & 0x100100 == 0x100100) #define SYN_CAP_MAX_DIMENSIONS(ex0c) ((ex0c) & 0x020000) /* synaptics modes query bits */ -- 1.7.2.3 -- Best regards, Li, Yan MeeGo Team, Opensource Technology Center, SSG, Intel Office tel.: +86-10-82171695 (inet: 8-758-1695) OpenPGP key: 5C6C31EF IRC: yanli on network irc.freenode.net -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
