Re: [RESEND] - HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Nov 2010 15:21:05 -0500
simon@xxxxxxxxxxxxx wrote:

> Doesn't look like this was picked up by anybody... at least there was no
> 'ack'.
> 

missing [PATCH] prefix (maybe [PATCH v2] ot v3 for the next round?), and
it was sent as attachment, while this list prefers patches in
the email body, with out-of-patch comments after the '---' separator.

> On behalf of Antonio, please find attached a git-ized version of the patch.
>

The commit short description is too long, limit it to 72 chars, and if
needed add a longer description in the commit message body.

Also the Signed-off-by line is missing, if you are the author, then it
would need your sign off Simon, if Antonio Orefice is the author, then
use his, with no need of the Reported-by.

The procedure may look tedious but the collaboration is based all on
that, and on the other hand if you have interest to have the
patch submitted, you have the motivation to conform to it; check out
Documentation/SubmittingPatches in the kernel dir.

> This just add the USB ID's. Builds OK against Linus' git tree, but I don't
> have the wheel to test.
> 
> Cheers,
> Simon Wood.
> http://www.speed-dreams.org

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Attachment: pgpU4uChG4Vxw.pgp
Description: PGP signature


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux