Re: [PATCH 1/2] HID: add support for force feedback in 'Thrustmaster F430 Force Feedback' steering wheel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Nov 2010 09:41:17 +0100
Antonio Orefice <aorefice77@xxxxxxxxx> wrote:

Hi Antonio, have I heard of you from unina?

> 
> --- hid-tmff.c-2.6.35	2010-11-16 13:54:29.563224822 +0100
> +++ hid-tmff.c	2010-11-16 13:46:42.549871515 +0100
> @@ -251,8 +252,12 @@
>  		.driver_data = (unsigned long)ff_rumble },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651),	/* FGT Rumble
> Force Wheel */
>  		.driver_data = (unsigned long)ff_rumble },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654),	/* FGT Force
> Feedback Wheel */
>  		.driver_data = (unsigned long)ff_joystick },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb65a),	/* F430 Force
> Feedback */
> +		.driver_data = (unsigned long)ff_joystick },
>  	{ }
>  };

Patch looks space damaged, check your email client settings. Why don't
you try using git (or at least quilt) instead of manual diffing? Tools
are there for a reason :)

Also, I really think the two patches can be folded into one, the commit
messages are telling us so.

Regards,
   Antonio Ospite

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Attachment: pgpkquPkwl71e.pgp
Description: PGP signature


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux