Hi Shubhrajyoti, On 11/16/2010 11:06 AM, Datta, Shubhrajyoti wrote: > Hi Anirudh, > >> -----Original Message----- >> From: linux-input-owner@xxxxxxxxxxxxxxx [mailto:linux-input- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Trilok Soni >> Sent: Wednesday, November 10, 2010 6:18 PM >> To: linux-kernel@xxxxxxxxxxxxxxx >> Cc: linux-input@xxxxxxxxxxxxxxx; rtc-linux@xxxxxxxxxxxxxxxx; linux-arm- >> msm@xxxxxxxxxxxxxxx; Anirudh Ghayal; Dmitry Torokhov >> Subject: [RFC v1 PATCH 5/6] input: pmic8058-othc: Add support for PM8058 >> based OTHC >> >> From: Anirudh Ghayal <aghayal@xxxxxxxxxxxxxx> >> >> One-touch headset controller is a hardware module in Qualcomm's PMIC8058. >> It supports headset insert/remove and switch press/release detection >> events >> over 3 MIC BIAS lines. The MIC BIAS lines can be configured to support >> headset detection or act as regular BIAS lines. > Could you help with the datasheet link if it is free. > datasheets are not available for open access. >> + >> +static int > If this is called only at init it can also be a devinit ? Ok. >> + if (rc) { >> + dev_dbg(&pd->dev, "Headset inserted during boot up!\n"); >> + dd->othc_ir_state = true; >> + input_report_switch(dd->othc_ipd, SW_HEADPHONE_INSERT, 1); >> + input_sync(dd->othc_ipd); >> + } > Not a comment. However I did not understand why the status at boot is required here. We need to report right status when the system boots up with headset inserted. >> + >> +fail_sw_irq: >> + free_irq(dd->othc_irq_ir, dd); >> +fail_ir_irq: >> + input_unregister_device(ipd); > Unregister and then falling back to free may not be what you intended. > Nope. Please see we are making othc_ipd = NULL, so everything should be fine. Thanks for the review comments. -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
