On Fri, Nov 12, 2010 at 02:41:08PM +0100, Oliver Neukum wrote: > Am Freitag, 12. November 2010, 03:48:36 schrieb Axel Lin: > > In current implementation, xpad_probe return 0 when > > usb_alloc_urb failed for xpad->bulk_out and kzalloc failed for xpad->bdata. > > > > This patch removes the initialization for error variable, > > assign the error code at the place the error happens instead. > > I am afraid you cannot let stand the order of allocations here anyway, > as xpad->irq_in is currently submitted before xpad->bulk_out is allocated. > That however is a race, because the callback for irq_in can call > xpad360w_process_packet(), which will in turn submit the bulk URB. > > I am afraid your patch is pointless unless the logic is also fixed. I do not think it is fair to call the patch pointless. It does fix the resource leak and can be a basis for further rework. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
