Re: [PATCH] evdev: discard oldest event on buffer overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 27, 2010 at 09:25:23PM -0700, Bill Gatliff wrote:
> On Wed, Oct 27, 2010 at 5:30 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > On Wed, Oct 27, 2010 at 05:11:28PM -0700, Bill Gatliff wrote:
> >> I still think my patch is a genuine improvement as-is, however.
> >
> > Sorry, I am unconvinced that it is an improvement.
> 
> The current code clobbers the queue suddenly and entirely on overflow,
> and replaces all the events therein with the current one.  My version
> simply discards the oldest event to make room for the newest one.
> I'll agree that my patch doesn't utterly and completely fix the
> problem, but I have verified that at least with a flood of incoming
> multitouch packets, the system still generally behaves itself--- which
> is far more than it was able to do with the code that I replaced.
> 

Is it still the case with 2.6.36? We added a code there to properly size
the length of evdev queues depending on the expected number of input
events in a packet.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux