> > + if (!einfo->buf) {
> > + einfo->buf = kzalloc(datalen, GFP_KERNEL | GFP_DMA);
> > + if (!einfo->buf) {
> > + ret = -ENOMEM;
> > + goto exit;
> > + }
> > + }
> > +
> > + memcpy(einfo->buf, p->custom_data, datalen);
>
> It looks like raw data from userspace is being passed on to the
> device. Is this sane? Is there already a data format used by other
> vibration/feedback devices that should be used here instead and
> translated into the form expected by the hardware?
It also seems to be using GFP_DMA not dma_alloc functions which looks a
bit odd and certainly isn't portable.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
