Re: [PATCH 2/3] Support enable Acer Launch Manager mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Carios, 

æ äï2010-10-18 æ 08:19 +0100ïCarlos Corbacho æåï
> On Monday 18 October 2010 03:32:22 Joey Lee wrote:
> > So, we choice remove rfkill-input then put the logic in x86/platform
> > driver?
> > A simple question:
> > Userland policy daemon or kernel module, which one we want to put the
> > wifi hotkey behavior implementation?
> 
> Pass. I really have no opinion on the above, as long as we pick something and 
> stick with it (i.e. not-another-rfkill-rewrite).
> 
> > > We don't have Launch Manager for Linux, and quite frankly, I hope we
> > > never see it - relying on random, vendor specific applications to drive
> > > this kind of functionality is just asking for trouble.
> > 
> > Acer BIOS team provide the function to OS for disable the EC hehavior,
> > it's available on window, why we hide it on Linux?
> 
> As an aside, just because Windows does something is not a good reason to do it 
> or expose on on Linux if it doesn't make any sense.
> 

M... We all know the wmi spec is from Microsoft and OEM/ODM base on it
to write their wmi function spec for develop their windows solution.
So, I thought we still need to reference the behavior on windows then do
our desicion on Linux.

Especially Linux kernel response BIOS by _OSI said we are Windows OS.

> > Either userland daemon or kernel module who want to implement the wifi
> > hotkey behavior, it need enable the launch-manager mode to disable the
> > default EC behavior on wifi hotkey.
> 
> When did Acer laptops start doing this then? The behaviour they always did in 
> the past was that pressing the wireless/ bluetooth/ 3G button sent out a 
> scancode, and is was then the job of something else to catch that (be it 
> rfkill-input or friends) and for that something else to then toggle the state.
> 
> Do the current batch of laptops then just 'magically' toggle the state without 
> needing rfkill-input?
> 

I will check when they start to use wmi event to replace the scancode or
maybe Acer ship wmi with different notebook family.
My 0001 patch transfer the wmi event to keycode, so, rfkill-input can
catch the keycode to work.

I agreed Dmitry's suggestion, we just direct enable the launch manager
mode to stop EC touch RF switch. Either use rfkill-input or userland
daemon to control the RF switch, we all need disable the default EC
behavior, it causes sometimes will enable/disalbe wifi/bluetooth switch
twice.

> (And do you actually have contact with someone on the Acer BIOS team? Because 
> I've never managed to get through to anyone at Acer, so would be interested to 
> know).
> 

Thank's for your suggestion, I will try to check your question.

> > If don't want provide the launch-manager mode parameter to userland, can
> > we just direct enable it?
> 
> Well, my point is more that we should figure out what we want, and then stick 
> with that. I don't want to add a pointless module paramater that all of three 
> people are ever going to use, and then have to support it working both ways.
> 

Like the above, I thought we just direct enable the lanuch manager mode
when acer-wmi driver detected the WMID3 available.


Thank's
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux