On Mon, Oct 18, 2010 at 09:13:14AM +0100, Hennerich, Michael wrote: > Dmitry Torokhov wrote on 2010-10-18: > > On Sun, Oct 17, 2010 at 09:24:28PM -0700, Dmitry Torokhov wrote: > >> On Sun, Oct 17, 2010 at 09:08:10PM -0700, Dmitry Torokhov wrote: > >>> On Fri, Oct 15, 2010 at 09:51:12PM -0400, Mike Frysinger wrote: > >>>> On Fri, Oct 15, 2010 at 06:40, <michael.hennerich@xxxxxxxxxx> > > wrote: > >>>>> Suppress events where pressure > pressure_max. > >>>>> These events come typically along with inaccurate X and Y > > samples. > >>>> > >>>> were you going to commit to the blackfin tree ? > >>>> > >>>>> --- a/drivers/input/touchscreen/ad7877.c > >>>>> +++ b/drivers/input/touchscreen/ad7877.c > >>>>> @@ -360,6 +360,13 @@ static int ad7877_rx(struct ad7877 *ts) > >>>>> Rt /= z1; > >>>>> Rt = (Rt + 2047) >> 12; > >>>>> > >>>>> + /* + * Sample found inconsistent, > >>>>> pressure is beyond + * the maximum. Don't report it > >>>>> to user space. + */ + if (Rt > > >>>>> ts->pressure_max) + return -EINVAL; > >>>> > >>>> this has spaces in the middle of your tab indents ... > >>> > >>> I took care of that on my side... > >>> > >> > >> BTW, I have a couple more small patches to the driver... Here is the > >> first: > >> > > > > And here is second: > > > > Input: ad7877 - switch to using threaded IRQ > > > > Instead of using asynchronous SPI API and then spinning waiting for > > SPI transfer to complete when disabling the device, let's use threaded > > IRQ model and spi_sync(). > > Tested on hardware - works great! > Thanks Michael, I'll also add a tested-by tag too then. > > > > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> > Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx> Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
