On Fri, Oct 15, 2010 at 06:06:37PM +0200, Maxim Levitsky wrote: > This is a result of last round of debug with > Sami R <maesesami@xxxxxxxxx>. > > Thank you Sami very much! > > The biggest bug I fixed is that, > I was clobbering the CIRCFG register after it is setup > That wasn't a good idea really > > And some small refactoring, etc. > > Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx> > --- > drivers/media/IR/ene_ir.c | 43 ++++++++++++++++++++----------------------- > 1 files changed, 20 insertions(+), 23 deletions(-) > > diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c > index dc32509..8639621 100644 > --- a/drivers/media/IR/ene_ir.c > +++ b/drivers/media/IR/ene_ir.c ... > @@ -282,6 +287,7 @@ static void ene_rx_setup(struct ene_device *dev) > ene_set_reg_mask(dev, ENE_CIRCFG, ENE_CIRCFG_CARR_DEMOD); > > /* Enable carrier detection */ > + ene_write_reg(dev, ENE_CIRCAR_PULS, 0x63); Looks sane, though I'd prefer to see symbolic bit names or some such thing here instead of 0x63. Not something to hold up the patch though. Acked-by: Jarod Wilson <jarod@xxxxxxxxxx> -- Jarod Wilson jarod@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
