Re: [PATCH 3/4] hid-multitouch: added support for Cypress TrueTouch panels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Le 14 oct. 10 à 14:06, Henrik Rydberg a écrit :

+static int cypress_compute_slot(struct mt_device *td)
+{
+	if (td->curcontactid != 0 || td->curcontact == 0)
+		return td->curcontactid;
+	else
+		return -1;
+}


Returned slots should always be valid, since the intent is to actually report data for the contact. If there is additional logic determining whether a touch is valid, like here, it can simply be added to the validity computation.

Then you'd need a second device-specific function, one that determines if a contact is valid. I was trying to minimize that, especially because it would be for the sake of one device only. Managing it in the compute_slot function makes sense to me, giving this function the semantics of "is this contact a real slot, and if yes which is it?".

Maybe we could add somthing like td->curvalid = false to the computation function? This would not work in the current code, but maybe we can make it work.

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux