On Tue, 2010-10-05 at 15:56 -0500, Jason Wessel wrote: > On 09/24/2010 11:08 PM, Dmitry Torokhov wrote: > > On Sat, Sep 25, 2010 at 02:14:32AM +0200, Maxim Levitsky wrote: > > > >> On Fri, 2010-09-24 at 15:58 -0500, Jason Wessel wrote: > >> > >>> On 09/24/2010 03:50 PM, Maxim Levitsky wrote: > >>> > >>>> > >>>> > >>>>> [Dropped nouveau list, because this is offtopic there] > >>>>> > >>>>> I pretty much got to the bottom of this. > >>>>> There are 2 separate issues: > >>>>> > >>>>> > >>>>> 1. SysRq handler is now a input 'filter', which means that it can 'eat' > >>>>> input events, so they don't show up on input bus. > >>>>> It does so while sysrq key is down. > >>>>> So sysrq and 'g' events never reach the kernel kbd driver and therefore > >>>>> the hack to release them doesn't work. > >>>>> > >>>>> 2. The kbd_clear_keys_helper injects the keyup events alright, but it > >>>>> doesn't inject SYN events, and therefore X evdev driver doesn't pick > >>>>> these injected events untill next SYN event. > >>>>> > >>>>> This patch makes key release work in expense of showing sysrq key to userspace, which isn't that good, > >>>>> because now Alt+SysRQ causes a screen capture by default. > >>>>> In my opinion the sysrq filter should stay. > >>>>> We should just make kdb hook into atkbd and do the key release there. > >>>>> This should both result in cleaner/more robust code, and make this issue disappear. > >>>>> I'll look at doing that. > >>>>> Nope, still same problem. Maybe more keys were released, but still pressing Alt+SysRQ+g second time doesn't break to the debugger. I pulled your kgdb-next branch which does contain these patches. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
