Re: [PATCH v3] serio: add support for PS2Mult multiplexer protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Thu, Sep 30, 2010 at 10:25 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Wed, Sep 29, 2010 at 04:45:53PM +0400, Dmitry Eremin-Solenikov wrote:
>> On Thu, Sep 23, 2010 at 8:44 PM, Dmitry Eremin-Solenikov
>> <dbaryshkov@xxxxxxxxx> wrote:
>> > PS2Mult is a simple serial protocol used for multiplexing several PS/2 streams
>> > into one serial data stream. It's used e.g. on TQM85xx serie of boards.
>> >
>> > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
>> > ---
>> >
>> > It actually depends on "serio: multiple children" patch. I'm not resending it
>> > as you were the originator of the latest version of the patch.
>>
>> So, what about this version of patch?
>>
>
> Looks better but I think you also need ->start() to make sure you do not
> try to deliver events too early. Does the following still work for you?

Sorry for the delay. Crashes w/o the attached patch.

-- 
With best wishes
Dmitry
From f3307e6693e04285c5be6c9dcf3aabc091f47686 Mon Sep 17 00:00:00 2001
From: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
Date: Thu, 7 Oct 2010 18:32:26 +0400
Subject: [PATCH] ps2mult: don't try to register empty serio pointers

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
---
 drivers/input/serio/ps2mult.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/input/serio/ps2mult.c b/drivers/input/serio/ps2mult.c
index 3664398..15341d1 100644
--- a/drivers/input/serio/ps2mult.c
+++ b/drivers/input/serio/ps2mult.c
@@ -196,9 +196,6 @@ static int ps2mult_connect(struct serio *serio, struct serio_driver *drv)
 
 	ps2mult_reset(psm);
 
-	for (i = 0; i <  PS2MULT_NUM_PORTS; i++)
-		serio_register_port(psm->ports[i].serio);
-
 	return 0;
 
 err_out:
-- 
1.7.1


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux