On 10/06/2010 11:46 AM, Dmitry Torokhov wrote: > Sorry, did not look far enough in the patch and missed the separate > allocation. But do you really want to allocate it separately? I think > the following patch simplifies and speeds up things at the expense of > slightly larger keymap structure. > > There are also fixes for proper __devinit/__devexit markups, locking of > open/close vs suspend/resume, keymap can be changed from userspace via > EVIOCSKEYCODE and bunch of other changes. > > Thanks. > > -- > Dmitry > > > Input: spear-kbd - assorted changes > > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx> > --- > > arch/arm/plat-spear/include/plat/keyboard.h | 3 > drivers/input/keyboard/spear-keyboard.c | 311 +++++++++++++-------------- > 2 files changed, 149 insertions(+), 165 deletions(-) Dmitry, We are busy with other activities, and can't test it right now. But i have reviewed it and it looks fine to me. Acked-by: Viresh Kumar <viresh.kumar@xxxxxx> Please include it in input-next repo. We will test it later on. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html