RE: [PATCHv5] input: ROHM BU21013 touch panel controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Henrik,

Thanks for your commenst.

> -----Original Message-----
> From: Henrik Rydberg [mailto:rydberg@xxxxxxxxxxx]
> Sent: Saturday, October 02, 2010 12:56 PM


> > +	has_x_sensors = hweight32(buf[0] & BU21013_SENSORS_EN_0_7);
> > +	has_y_sensors = hweight32(((buf[1] & BU21013_SENSORS_EN_8_15) |
> > +		((buf[2] & BU21013_SENSORS_EN_16_23) << SHIFT_8)) >>
> SHIFT_2);
> > +	if (!has_x_sensors || !has_y_sensors)
> > +		return 0;
> 
> 
> I believe this line will lead to fingers stuck in the down position.
> 

This case is only used when there is only x or y -co-ordinates or both are null.
This case is coming either before pen down report or after pen up reporting.
So, this is not an issue.

Thanks & Regards,
Naveen
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux