Hi Rudy, > >>> + case HID_DG_WIDTH: >>> + sd->w = value; >>> + break; >>> + case HID_DG_HEIGHT: >>> + sd->h = value; >>> + sitronix_filter_event(sd, input); >> >> >> This kind of construction is unfortunate, because similar >> devices may have a different attribute set, of the attributes >> may appear in a different order. Better would be to allow to >> first collect all attributes in random order, then perform the >> contact update. > > How could I know that all attributes are collected ? > In our device, HID_DG_HEIGHT is the last field of finger. > Is there any reference code to which I can refer ? There will be in a little bit. The comment is really more of a general note applicable to all the current drivers, and a moot point in this particular instance now that it will be merged with the hid-stantum driver. Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
