On Thu, 23 Sep 2010 10:16:43 -0400 Alan Ott <alan@xxxxxxxxxxx> wrote: > > On Sep 23, 2010, at 7:51 AM, Ville Tervo wrote: > > > Hi Alan, > > > > One comment. > > > > How about a variable called ret and using that to return len or > > errno? It > > would eliminate code dublication. > > > > Hi Ville, > > Where specifically? In which function? I've gone through it a couple > of times and failed to find return statements which are superfluous. > Maybe I'm missing something fundamental? > I guess he's referring to the return paths (normal, err_restartsys, err_eio) in hidp_get_raw_report(), they could be merged into a generic "out:" path by parametrizing the return value. I don't know if Alan prefers explicit error paths, for me it's OK either way. Regards, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpohrwrcpsbO.pgp
Description: PGP signature
