RE: [PATCH v6 1/2] input: add support for Nomadik SKE keypad controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

>-----Original Message-----
>From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx]
>
>Out of curiosity, did you try the patch that did not do polling? What
>was the breakage?

Yes. I did test the non-polling patch which you inlined in the mail.
And the issue was same: I missed the actual press/release report
events to the user space. With the threaded_irq one, I got this working
back. 

As I mentioned, I have a couple of other keypad drivers with the
same key layouts passed from platform data. I always compare the
event reports from the SKE keypad to those ones like STMPE/TC35893
keypad controllers. And hence my observation that if I miss some
events which is not captured by getevents, then this driver is doing
something wrong.

>I was also hoping you'd use it as a base for applying the threaded patch
>- I did a few fixups and changed the probe routine a bit.

Ohh. I overlooked the changes in the probe function then. Surely I will incorporate it
and send it out if you are okay with the v6 IRQ handling.

Regards,
Sundar
P.S: Again a tremendous thanx to you for being so persistent and helpful.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux