On Tue, 21 Sep 2010, Greg KH wrote: > > It doesn't hit you if you are calling usb_register_dev() for all the > > instances you have, as the first device will have minor '0', the > > second one '1', etc. > > > > But if you are calling usb_find_interface() for devices that have never > > been registered through usb_register_dev(), then you have a problem, as > > usb_find_interface() will match those unregistered devices (as minor == 0 > > in such cases). > > > > This is probably quite rare scenario, and hiddev (which might be the only > > in-kernel driver doing this?) has moved to usb_find_interface() only > > recently. > > Ah, ok, that makes sense, I never thought of someone calling that > function if they had never registered a device :) > > When did hiddev make this change? We need to know that for the -stable > backport of this patch. This all comes from BKL removal in bd25f4dd697275. Which has been merged for 2.6.36-rc1, so it hasn't hit any release yet, so there shouldn't be anything needed for any -stable release. > Alan, care to resend the patch in a format I can apply it? It's definitely 2.6.36 material. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
