Hi Dmitry, >-----Original Message----- >From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] >> + >> + /* disable auto scan interrupt; mask the interrupt generated */ >> + ske_keypad_set_bits(keypad, SKE_IMSC, ~SKE_KPIMA, 0x0); >> + ske_keypad_set_bits(keypad, SKE_ICR, 0x0, SKE_KPICA); >> + >> + mod_timer(&keypad->timer, jiffies + 2); >> + > >I expected you would do "return IRQ_HANDLED;" here so that hardware >polling is done exclusively in timer handler. > What I thought is: enable the timer by default; so that in case we find out the ASRs aren't stable, the reporting automatically will get deferred to the timer. In a normal case, when the ASRs are stable, the reporting gets done by the IRQ handler; in case they aren't, the reporting will get done by the timers. Is this not correct? Regards, Sundar -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
