On Friday, September 10, 2010, Chris Bagwell <chris@xxxxxxxxxxxxxx> wrote:
> Ping would you be able to comment on question at end?
>
> On Thu, Sep 9, 2010 at 4:46 PM, Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>> On Thu, Sep 09, 2010 at 04:34:35PM -0500, Chris Bagwell wrote:
>>> On Wed, Sep 8, 2010 at 11:14 PM, Dmitry Torokhov
>>> <dmitry.torokhov@xxxxxxxxx> wrote:
>>> > On Wed, Sep 08, 2010 at 11:02:31PM -0500, chris@xxxxxxxxxxxxxx wrote:
>>> >> From: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>>> >>
>>> >> This adds support for Pen on Bamboo Pen and Bamboo Pen&Touch
>>> >> devices. Touchpad is handled by previous Bamboo Touch
>>> >> logic.
>>> >>
>>> >> Signed-off-by: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>>> >> ---
>>> >> drivers/input/tablet/wacom_wac.c | 75 ++++++++++++++++++++++++++++++++++++++
>>> >> 1 files changed, 75 insertions(+), 0 deletions(-)
>>> >>
>>> >> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
>>> >> index 2f7ed9a..9cc0cf0 100644
>>> >> --- a/drivers/input/tablet/wacom_wac.c
>>> >> +++ b/drivers/input/tablet/wacom_wac.c
>>> >> @@ -904,10 +904,71 @@ static int wacom_bpt_touch(struct wacom_wac *wacom)
>>> >> return 0;
>>> >> }
>>> >>
>>> >> +static int wacom_bpt_pen(struct wacom_wac *wacom)
>>> >> +{
>>> >> + struct input_dev *input = wacom->input;
>>> >> + unsigned char *data = wacom->data;
>>> >> + int prox = 0, x = 0, y = 0, p = 0, d = 0, pen = 0, btn1 = 0, btn2 = 0;
>>> >> +
>>> >> + prox = (data[1] & 0x10) && (data[1] & 0x20);
>>> >
>>> > prox = (data[1] & 0x30) == 0x30;
>>> >
>
> The 0x30 check would boil down to simplest safety check for unknown ID's.
>
> Ping, if you could confirm this I would be happy to document bit
> meaning in patch update.
I do not remember the detail of this protocol off the top of my head.
And I can not access it in the next 2 weeks. I feel Chris is right.
However, if reverse engineering does confirm your comments, you'll
have to wait.
Ping
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
