On Thu, Sep 09, 2010 at 07:16:19PM +0530, Trilok Soni wrote: > On 9/9/2010 6:50 PM, Naveen Kumar GADDIPATI wrote: > > Hi Trilok, > > > >> -----Original Message----- > >> From: Trilok Soni [mailto:tsoni@xxxxxxxxxxxxxx] > >> Sent: Thursday, September 09, 2010 5:41 PM > >> To: Naveen Kumar GADDIPATI > >> Cc: Dmitry Torokhov; linux-input@xxxxxxxxxxxxxxx; > >> STEricsson_nomadik_linux > > > > > >>> + > >>> +static struct i2c_driver bu21013_driver = { > >>> + .driver = { > >>> + .name = DRIVER_TP, > >>> + .owner = THIS_MODULE, > >>> + }, > >>> + .probe = bu21013_probe, > >>> +#ifdef CONFIG_PM > >>> + .suspend = bu21013_suspend, > >>> + .resume = bu21013_resume, > >>> +#endif > >> > >> Better to move these suspend and resume to dev_pm_ops. > >> > > How we could dev_pm_ops in i2c driver structure? > > > > Refer: drivers/input/keyboard/adp5588-keys.c as example. > Hm, indeed I forgot that i2c has been fully wired for dev_pm_ops. I should enforce its use then. Thank you for reminding Trilok. I wonder if someone could wire SPI as well... -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
