On Wed, Sep 08, 2010 at 04:15:10PM +0530, Trilok Soni wrote:
> Hi Naveen,
>
> On 9/8/2010 3:54 PM, Naveen Kumar GADDIPATI wrote:
> > Hi Dmitry,
> >
> > From: Naveen Kumar Gaddipati <naveen.gaddipati@xxxxxxxxxxxxxx>
> >
> > Added the ROHM based bu21013 capacitive touch panel controller
> > driver support with i2c interface.
> >
> > Signed-off-by: Naveen Kumar Gaddipati <naveen.gaddipati@xxxxxxxxxxxxxx>
> > ---
> > Modifications in v1:
> > --Updated with the Dmitry comments on Patch 0, but fuzz is not used to get the
> > delta between two co-ordinates in multi touch.
> > --Updated with the Trilok comments on Patch 0
>
> Thanks for the updates.
>
> >
> > +config TOUCHSCREEN_BU21013
> > + tristate "BU21013 based touch panel controllers"
> > + depends on I2C
> > + help
> > + Say Y here if you have a bu21013 touchscreen connected to
> > + your system.
> > +
> > + If unsure, say N.
> > +
> > + To compile this driver as a module, choose M here: the
> > + module will be called bu21013_ts.
> > +
>
> Dmitry, we do follow the alphabetical order for Kconfig and Makefile for touchscreen folder, right?
>
Yes. Mostly for my benefit though :) - if everyone adds their driver at
the end I need to fix up conflicts on every one of them and also when I
move the patches in my queue up and down. Having them listed
alphabetically reduces chances of conflicts.
> > +
> > +/**
> > + * bu21013_report_pen_down() - reports the pen down event
> > + * @data:bu21013_ts_data structure pointer
> > + * @count:touch count
> > + *
> > + * This function used to report the pen down interrupt to
> > + * input subsystem and returns none
> > + */
> > +static void bu21013_report_pen_down(struct bu21013_ts_data *data, int count)
> > +{
> > + input_report_abs(data->in_dev, ABS_X, data->x_pos[0]);
> > + input_report_abs(data->in_dev, ABS_Y, data->y_pos[0]);
> > + input_report_key(data->in_dev, BTN_TOUCH, 1);
> > +
> > + if (data->chip->multi_touch) {
> > + if (count > 1)
> > + input_report_key(data->in_dev, BTN_2, 1);
>
> Dmitry,
>
> Do you prefer the method of supporting ST and MT like the code above? My preference
> would be to keep only MT, because the chip supports MT.
We still need to support the ST so that older clients can work with the
device; but yes, MT events should be sent unconditionally and BTN_2
should not be abused for multitouch indicator.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
