On Tue, 7 Sep 2010, Jiri Slaby wrote: > >>>> + > >>>> + ret = ntrig_version_string(&data[2], buf); > >>>> + > >>>> + dev_info(&hdev->dev, > >>>> + "Firmware version: %s (%02x%02x %02x%02x)\n", > >>>> + buf, data[2], data[3], data[4], data[5]); > >>>> + > >>>> + kfree(buff); > >> > >> In any case, this doesn't compile... > >> > >>>> + } > > > > Jiri, I moved the code to a separate function as Dmitry suggested, and compiled a kernel from a clean tree using > > gcc-3.4 (I think). > > This version is OK. In the previous one, there was > char *buf; > ... > kfree(buff); Dmitry, Jiri, thanks a lot for taking care reviewing the patch while I have been lagging behind. Now applied, thanks Rafi. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
