On 09/03/2010 03:01 PM, Ping Cheng wrote: [...] > + input_report_key(input, BTN_LEFT, (data[1] & 0x08) != 0); > + input_report_key(input, BTN_MIDDLE, (data[1] & 0x04) != 0); > + input_report_key(input, BTN_4, (data[1] & 0x02) != 0); > + input_report_key(input, BTN_RIGHT, (data[1] & 0x01) != 0); > > Since you are assigning meaningful defaults to three of the tablet > buttons instead of using BTN_#, can we move one more step to make the > fourth button useful out-of-box too? I am thinking of something like > BTN_FORWARD and BTN_BACK while getting rid of the BTN_MIDDLE. So, it > would be: > > input_report_key(input, BTN_LEFT, (data[1] & 0x08) != 0); > input_report_key(input, BTN_FORWARD, (data[1] & 0x04) != 0); > input_report_key(input, BTN_BACK, (data[1] & 0x02) != 0); > input_report_key(input, BTN_RIGHT, (data[1] & 0x01) != 0); > > Does this make sense to you? Well, this is all a matter of taste, isn't it. If middle-button emulation works out of the box, for the benefit of us old X users who seem unwilling to ever let go of the click-to-paste functionality, then I would not mind terribly. Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
