Re: [PATCH v2] Input: wm97xx-core - add retries to wm97xx_read_aux_adc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 02, 2010 at 04:16:37PM -0400, Eric Millbrandt wrote:

> +       if (timeout >= 5)
> +               wm->codec->dig_enable(wm, false);
> +

Looks good but I think it'd be better to log an error here at least at
debug level since I bet people won't do such a good job of checking the
return value and this shouldn't be happening in normal operation.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux