On 09/02/2010 11:02 PM, Ping Cheng wrote: [...] >> @@ -1079,6 +1134,31 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev, >> case PENPARTNER: >> __set_bit(BTN_TOOL_RUBBER, input_dev->keybit); >> break; >> + >> + case BAMBOO_PT: >> + __clear_bit(ABS_MISC, input_dev->absbit); >> + >> + if (features->device_type != BTN_TOOL_TRIPLETAP) >> + break; >> + >> + __set_bit(BTN_LEFT, input_dev->keybit); >> + __set_bit(BTN_MIDDLE, input_dev->keybit); >> + __set_bit(BTN_RIGHT, input_dev->keybit); > > An if-else is needed here instead of the break since there is a > pen-only bamboo model in the market. If you don't have time to update > it, you can leave it to Chris. He can make the changes when he work on > the other models. Thanks, I can see that will make subsequent patches nicer. There will most likely be another round of patches, I will update it then, and leave the rest to Chris. Cheers, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
