On 09/02/2010 02:12 AM, Rafi Rubin wrote:
>
>
> On 09/01/2010 04:12 PM, Jiri Slaby wrote:
>> On 09/01/2010 11:48 AM, Rafi Rubin wrote:
>>> --- a/drivers/hid/hid-ntrig.c
>>> +++ b/drivers/hid/hid-ntrig.c
>>> @@ -90,6 +90,26 @@ struct ntrig_data {
>>> };
>>>
>>>
>>> +/*
>>> + * This function converts the 4 byte raw firmware code into
>>> + * a string containing 5 comma separated numbers.
>>> + */
>>> +static int ntrig_version_string(unsigned char *raw, char *buf)
>>> +{
>>> + __u8 a = (raw[1]& 0b00001110)>> 1;
>>> + __u8 b = (raw[0]& 0b00111100)>> 2;
>>> + __u8 c = ((raw[0]& 0b00000011)<< 3) | ((raw[3]&
>>> 0b11100000)>> 5);
>>> + __u8 d = ((raw[3]& 0b00000111)<< 3) | ((raw[2]&
>>> 0b11100000)>> 5);
>>> + __u8 e = raw[2]& 0b00000111;
>>
>> This won't compile with gcc 3.4 which we still support. Maybe time to
>> kill the support?
>>
>> ...
>
> Why not?
Beacuse it's a gnu extension added in gcc 4.3. (I though it's in gcc 4.0
initially, but it's not. So you cannot use it in the kernel code at all.)
regards,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
