On 08/31/2010 08:41 PM, Chase Douglas wrote:
> The Magic Mouse device is very precise. No driver filtering of input
> data needs to be performed.
>
> Signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
> Acked-by: Michael Poole <mdpoole@xxxxxxxxxxx>
> ---
I am still not sure this is a good idea. Bandwidth from MT devices is a big
deal. A statement roughly how much data comes out of mtdev (which does the
filtering for type A devices) before and after this change would be reassuring.
Cheers,
Henrik
> drivers/hid/hid-magicmouse.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
> index 98bbc53..0fe2464 100644
> --- a/drivers/hid/hid-magicmouse.c
> +++ b/drivers/hid/hid-magicmouse.c
> @@ -357,11 +357,11 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
> __set_bit(EV_ABS, input->evbit);
>
> input_set_abs_params(input, ABS_MT_TRACKING_ID, 0, 15, 0, 0);
> - input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 4, 0);
> - input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 4, 0);
> - input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 1, 0);
> + input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
> + input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
> + input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 0, 0);
> input_set_abs_params(input, ABS_MT_POSITION_X, -1100, 1358,
> - 4, 0);
> + 0, 0);
> /* Note: Touch Y position from the device is inverted relative
> * to how pointer motion is reported (and relative to how USB
> * HID recommends the coordinates work). This driver keeps
> @@ -369,7 +369,7 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
> * inverse of the reported Y.
> */
> input_set_abs_params(input, ABS_MT_POSITION_Y, -1589, 2047,
> - 4, 0);
> + 0, 0);
> }
>
> if (report_undeciphered) {
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
