Re: [PATCH 2.6.35.3] wacom: Fix mousewheel up/down regression for old wacom tablets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 25, 2010 at 07:10:00PM +0100, Mike Auty wrote:
> This fixes a regression introduced in
> 3b57ca0f80c5c8994b5b1e3d3f904cfe727951f2.
> 
> The data[6] byte contains either 1 or -1 depending on the whether the
> mouse wheel on older wacom tablets is moved down (1) or up (-1).  The
> patch introduced in the above commit changed the cast from (signed char)
> to (signed).  When cast as a signed integer and negated, the value of -1
> (stored in the byte as 0xff) became -255 rather than 1.  This patch
> reverts the cast to a (signed char) and also removes an unnecessary
> (signed) cast, as all the values operated on are bitmasked.
> 
> Signed-off-by: Mike Auty <ikelos@xxxxxxxxxx>
> Reviewed-by: Ping Cheng <pingc@xxxxxxxxx>

Applied, thank you Mike.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux