Hi Christopher, Some generic review comments for this patch 1. Normally, defconfig should be a separate patch. You need not post the entire defconfig, but only the changes to the Makefiles and the Kconfig files. 2. All RMI specific files can be moved to a separate driver folder in input/ like drivers/input/rmi/*. 3. Lots of Hungarian notation in the code. Please refer this snippet. >------------------------------------ >CODE CONTAINS HUNGARIAN NOTATION > >Some coding guidlines at some companies require that you type the name >of your variables using the infamous hungarian notation: >http://en.wikipedia.org/wiki/Hungarian_notation > >We have an internal coding guideline that touches on the >subject: >http://swadvice.lud.stericsson.com/guideline.aspx?nr=57&ver=latest > >According to the Linux kernel inventor Linus Torvalds in his document >Documentation/CodingStyle in the Linux kernel: > >"Encoding the type of a function into the name (so-called Hungarian >notation) is brain damaged-the compiler knows the types anyway and can >check those, and it only confuses the programmer." > >Remove all instances of hungariang notation in the code please. >Includes prefixing pointers with p_*, naming structs with s_*, enums >with e_*, suffixes like *32b etc etc. >----------------------------------- > We are also using the Synaptics RMI4 touch pad on our U8500 platform. We had to make some changes to these posted drivers to make it work on our platform. Also, we modified the touch screen driver to be compliant to the kernel coding guidelines, but as a stand alone driver though. I will soon post out an RFC for our patch which we got working on our board. Please do have a look and we would like you guys to incorporate these changes into your final patch sets as well, so that we can avoid any re-works later on when your patch set gets merged into the mainline kernel. Cheers! Naveen -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
