Hello Henrick, > -----Original Message----- > From: Henrik Rydberg [mailto:rydberg@xxxxxxxxxxx] > Sent: Thursday, August 05, 2010 4:07 PM > To: Kevin McNeely > Cc: Dmitry Torokhov; David Brown; Trilok Soni; Fred; Samuel Ortiz; Eric > Miao; Ben Dooks; Simtec Linux Team; Todd Fischer; Arnaud Patard; Sascha > Hauer; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] i2c: cyttsp i2c and spi touchscreen driver init > submit > > On 08/05/2010 08:12 PM, Kevin McNeely wrote: > > > From: Fred <fwk@xxxxxxxxxxxxxxxxxxxxxxxxx> > > > > This is a new touchscreen driver for the Cypress Semiconductor > > cyttsp family of devices. This updated driver is for both the i2c > and spi > > versions of the devices. The driver code consists of common core code > for > > both i2c and spi driver. This submission is in response to review > comments > > from the initial submission. > > > > Signed-off-by: Kevin McNeely <kev@xxxxxxxxxxx> > > --- > > > General impression: There is a lot of useful code in here, but as > already > pointed out, well over half of it should not be part of the kernel > driver. > > Suggestion 1: Clean out the internal state code and use MT protocol B > instead. > > Suggestion 2: Cut out the single touch calculation, as already pointed > out by > Trilok. Why not submit it to the mtdev project instead? The problem is > generic > to all new MT drivers, so a common solution while waiting for full MT > support in > userspace could be useful. I will remove the ST code and polling completely. However, I would like to keep the MT Protocol A. Our solution allows The platform builder to select to use MT protocol B or not as part of platform_data in the board configuration. If it makes more sense, I can reverse the code to default to protocol B and allow the platform builder developer to select protocol A. Thank you for the invitation to submit to the mtdev project. I defer to Dmitry if I should make the next update into the mtdev project. Thank you for your review. -kev > > Thanks, > Henrik --------------------------------------------------------------- This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message. --------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
