> I have a patch to drop the lock in serial_core.h, I'll post that > tomorrow hopefully, just checking if there's any objection there ? The Fundamentally - no. However the impact it has on a lot of the drivers will be significant and you'll be submitting a huge patch pile to fix up all the locking assumptions (for one it means port->tty might change across any call that ends up in sysrq) > serial drivers might need to be audited a bit to make sure they cope > with the lock being dropped and re-acquired around the sysrq call. Architecturally I think it would make more sense to add a new sysrq helper which merely sets a flag, and check that flag at the end of the IRQ when dropping the lock anyway. Otherwise it'll be a huge amount of work to even build test all those consoles. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
