Hi Xiaolong, On Mon, Jul 26, 2010 at 11:45:43PM +0800, Xiaolong Chen wrote: > Hi, Dmitry > > Following your comments, add the CONFIG_GPIOLIB and update the > patch based on the linux-next. If there is any comments and > suggestion, please feel free let me know. > > I think we need to protect the code you are adding with #ifdef > CONFIG_GPIOLIBi and provide the stubs in case gpiolib is not > available. This will also force splitting the gpio hanlding code > into separate functions so that it is easier to read. Please see > how it is done in ad7879 driver. > Done. > > Also if would be great if you generated the patch against the > version of the driver that is ither in linux-next or in the 'next' > branch of my tree as there a few changes clashing with yours. > Done. > I have applied the patch with minor changes to my 'next' branch on kernel.org. Would you mind taking a look there to make sure it is all in order? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html