Hi Mike,
On Wed, Jul 21, 2010 at 09:50:12AM -0400, Mike Frysinger wrote:
> On Thu, Jul 1, 2010 at 03:53, Dmitry Torokhov wrote:
> > Input: adxl34 - make enable/disable separate from suspend/resume
>
> this should be "adxl34x" i think to match the style we've used in the
> past and the actual driver name
>
> > -void adxl34x_enable(struct adxl34x *ac)
> > +void adxl34x_resume(struct adxl34x *ac)
> > {
> > mutex_lock(&ac->mutex);
> > - __adxl34x_enable(ac);
> > +
> > + if (ac->suspended && !ac->disabled && ac->opened)
> > + __adxl34x_enable(ac);
> > +
> > + ac->suspended= false;
>
> ERROR: spaces required around that '=' (ctx:VxW)
> #191: FILE: drivers/input/misc/adxl34x.c:435:
> + ac->suspended= false;
>
> > }
> >
> > -EXPORT_SYMBOL_GPL(adxl34x_enable);
> > +EXPORT_SYMBOL_GPL(adxl34x_resume);
>
> while you're here, might want to delete the newline after the brace to
> avoid the checkpatch warning:
Thanks for noticing these issues however as the original change is quite
buried I opted to roll these changes into another patch.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
