Hi Xiaolong, On Tue, Jul 20, 2010 at 08:49:36PM +0800, Xiaolong Chen wrote: > Hi Dmitry, > > There is still some issue on my company mail system, so change to this mail to submit the patch. > > Looks like this time haven't the line wrapped issue, any further comments and suggestion, please let me know. > I think we need to protect the code you are adding with #ifdef CONFIG_GPIOLIBi and provide the stubs in case gpiolib is not available. This will also force splitting the gpio hanlding code into separate functions so that it is easier to read. Please see how it is done in ad7879 driver. Also if would be great if you generated the patch against the version of the driver that is ither in linux-next or in the 'next' branch of my tree as there a few changes clashing with yours. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
